AMDB autogen ordering #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve build issue where AMDB autogen files were missing module configurations in Zephyr compilation. The problem occurred because the spf_libs_config_parser script executed before module JSON files were generated during the CMake configuration phase. Move the spf_libs_config_parser execution after add_subdirectory() calls for fwk and modules directories. This ensures module AMDB configuration JSON files are created before the autogen script processes them, allowing proper inclusion of module configurations in the generated AMDB files. The timing issue is specific to the CMake configuration stage where execute_process() and add_subdirectory() both run, but in the wrong order for this dependency chain. Signed-off-by: Aditya Rathi <[email protected]>
Replace file(GLOB_RECURSE) with explicit listing of autogen source files to ensure they are properly included in the AMDB library build. Due to the reordering of spf_libs_config_parser script execution in the root CMakeLists.txt, AMDB autogen files are now generated later in the CMake configuration phase. The GLOB_RECURSE operation executes before file generation, resulting in an empty file list and subsequent linker errors for missing symbols when autogen files are not linked to the AMDB library. Explicitly list the four required autogen source files: - spf_static_build_config.c - spf_shared_build_config.c - spf_static_build_config_private.c - spf_shared_build_config_private.c Signed-off-by: Aditya Rathi <[email protected]>
quic-plai
approved these changes
Feb 1, 2026
quic-plai
approved these changes
Feb 1, 2026
qti-sbojja
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve build issue where AMDB autogen files were missing module
configurations in Zephyr compilation. The problem occurred because
the spf_libs_config_parser script executed before module JSON files
were generated during the CMake configuration phase.
Move the spf_libs_config_parser execution after add_subdirectory()
calls for fwk and modules directories. This ensures module AMDB
configuration JSON files are created before the autogen script
processes them, allowing proper inclusion of module configurations
in the generated AMDB files.
Replace file(GLOB_RECURSE) with explicit listing of autogen source files
to ensure they are properly included in the AMDB library build.
Due to the reordering of spf_libs_config_parser script execution in the
root CMakeLists.txt, AMDB autogen files are now generated later in the
CMake configuration phase. The GLOB_RECURSE operation executes before
file generation, resulting in an empty file list and subsequent linker
errors for missing symbols when autogen files are not linked to the
AMDB library.